From a92f617f241773add61f5c0938ac1fe9f4cb4200 Mon Sep 17 00:00:00 2001 From: Simon Gerber Date: Tue, 27 Sep 2022 17:34:20 +0200 Subject: [PATCH 1/2] Use static tags for `acme-dns` and `caddy` container images --- class/defaults.yml | 4 ++-- .../acme-dns/acme-dns/acme-dns/20_deployment.yaml | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/class/defaults.yml b/class/defaults.yml index 33e290c..1d954ec 100644 --- a/class/defaults.yml +++ b/class/defaults.yml @@ -9,11 +9,11 @@ parameters: acme-dns: registry: docker.io repository: joohoi/acme-dns - tag: latest + tag: v1.0 caddy: registry: docker.io repository: caddy/caddy - tag: alpine + tag: 2.6.1-alpine sqlite: registry: docker.io repository: nouchka/sqlite3 diff --git a/tests/golden/defaults/acme-dns/acme-dns/acme-dns/20_deployment.yaml b/tests/golden/defaults/acme-dns/acme-dns/acme-dns/20_deployment.yaml index 2bd0e25..2511af5 100644 --- a/tests/golden/defaults/acme-dns/acme-dns/acme-dns/20_deployment.yaml +++ b/tests/golden/defaults/acme-dns/acme-dns/acme-dns/20_deployment.yaml @@ -28,8 +28,8 @@ spec: containers: - args: [] env: [] - image: docker.io/joohoi/acme-dns:latest - imagePullPolicy: Always + image: docker.io/joohoi/acme-dns:v1.0 + imagePullPolicy: IfNotPresent livenessProbe: failureThreshold: 3 httpGet: @@ -68,7 +68,7 @@ spec: - --config - /etc/caddy/caddy.json env: [] - image: docker.io/caddy/caddy:alpine + image: docker.io/caddy/caddy:2.6.1-alpine imagePullPolicy: IfNotPresent livenessProbe: failureThreshold: 3 @@ -109,7 +109,7 @@ spec: envFrom: - secretRef: name: acmedns-basicauth - image: docker.io/caddy/caddy:alpine + image: docker.io/caddy/caddy:2.6.1-alpine imagePullPolicy: IfNotPresent name: render-caddy-config ports: [] From 55d4cabf3c1e7955540c30737e0059e95638a06d Mon Sep 17 00:00:00 2001 From: Simon Gerber Date: Wed, 28 Sep 2022 10:05:34 +0200 Subject: [PATCH 2/2] Note why we're still using `latest` for the sqlite image --- class/defaults.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/class/defaults.yml b/class/defaults.yml index 1d954ec..84e91ce 100644 --- a/class/defaults.yml +++ b/class/defaults.yml @@ -17,6 +17,9 @@ parameters: sqlite: registry: docker.io repository: nouchka/sqlite3 + # We use the sqlite3 image for K8up-based backups. Unfortunately + # there's no tags other than latest for the nouchka/sqlite3 image, so + # we're using latest here. tag: latest api: