From 40b7633d4df2f220b3e668324917ae68f2a40b22 Mon Sep 17 00:00:00 2001 From: Thuong Tran Date: Mon, 5 Jul 2021 15:38:30 +0700 Subject: [PATCH 1/3] fix(android): Fix error com.facebook.react.bridge.NoSuchKeyException --- .../java/com/proyecto26/inappbrowser/RNInAppBrowser.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/android/src/main/java/com/proyecto26/inappbrowser/RNInAppBrowser.java b/android/src/main/java/com/proyecto26/inappbrowser/RNInAppBrowser.java index 745abe0..b3bce8b 100644 --- a/android/src/main/java/com/proyecto26/inappbrowser/RNInAppBrowser.java +++ b/android/src/main/java/com/proyecto26/inappbrowser/RNInAppBrowser.java @@ -64,10 +64,11 @@ public class RNInAppBrowser { private static final Pattern animationIdentifierPattern = Pattern.compile("^.+:.+/"); public Integer setColor(CustomTabsIntent.Builder builder, final ReadableMap options, String key, String method, String colorName) { - String colorString = options.getString(key); + String colorString = null; Integer color = null; try { - if (colorString != null) { + if (options.hasKey(key)) { + colorString = options.getString(key); color = Color.parseColor(colorString); Method findMethod = builder.getClass().getDeclaredMethod(method, int.class); findMethod.invoke(builder, color); From 80a3dae90bd4562b4c87c9fd7afb8a9af8acabed Mon Sep 17 00:00:00 2001 From: Juan David Nicholls Cardona Date: Mon, 5 Jul 2021 12:14:14 -0500 Subject: [PATCH 2/3] Release 3.6.3 --- CHANGELOG.md | 7 ++++++- package.json | 2 +- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 252c275..d574604 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -22,6 +22,10 @@ in case of vulnerabilities. ## [Unreleased] +## [3.6.3] - 2021-07-05 + +- fix(android): Fix error com.facebook.react.bridge.NoSuchKeyException by [@thuongtv-vn](https://github.com/thuongtv-vn) ([#283](https://github.com/proyecto26/react-native-inappbrowser/pull/283)). + ## [3.6.2] - 2021-07-03 ### Fixed @@ -197,7 +201,8 @@ Missing tags for previous versions 🤷‍♂ - Fix `EventBusException` on **Android** by [@Almouro](https://github.com/Almouro) ([9cf4cbb](https://github.com/proyecto26/react-native-inappbrowser/commit/9cf4cbb58d55c8b534dabac6791e6a2a5428253f)). -[Unreleased]: https://github.com/proyecto26/react-native-inappbrowser/compare/v3.6.2...HEAD +[Unreleased]: https://github.com/proyecto26/react-native-inappbrowser/compare/v3.6.3...HEAD +[3.6.3]: https://github.com/proyecto26/react-native-inappbrowser/compare/v3.6.2...v3.6.3 [3.6.2]: https://github.com/proyecto26/react-native-inappbrowser/compare/v3.6.1...v3.6.2 [3.6.1]: https://github.com/proyecto26/react-native-inappbrowser/compare/v3.6.0...v3.6.1 [3.6.0]: https://github.com/proyecto26/react-native-inappbrowser/compare/v3.5.1...v3.6.0 diff --git a/package.json b/package.json index 4e4bd6e..a0f44b8 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "react-native-inappbrowser-reborn", - "version": "3.6.2", + "version": "3.6.3", "description": "InAppBrowser for React Native", "main": "index.js", "scripts": { From 997de9f4d867efdecf6529daf45a04effb8b97fa Mon Sep 17 00:00:00 2001 From: Juan David Nicholls Cardona Date: Mon, 5 Jul 2021 12:15:29 -0500 Subject: [PATCH 3/3] Fix README --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index d574604..b15598a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -24,6 +24,7 @@ in case of vulnerabilities. ## [3.6.3] - 2021-07-05 +### Fixed - fix(android): Fix error com.facebook.react.bridge.NoSuchKeyException by [@thuongtv-vn](https://github.com/thuongtv-vn) ([#283](https://github.com/proyecto26/react-native-inappbrowser/pull/283)). ## [3.6.2] - 2021-07-03