Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

labels section custom color label value doesn't support number? #507

Closed
xingmin860818 opened this issue Mar 9, 2019 · 7 comments · Fixed by #516
Closed

labels section custom color label value doesn't support number? #507

xingmin860818 opened this issue Mar 9, 2019 · 7 comments · Fixed by #516

Comments

@xingmin860818
Copy link

I set the config file for some customized settings,when I configed the label sections custom filed ,my severity label match value like P1,P2,P3, but the web UI doesn't seems to support that ,no change color for that label.

@prymitive
Copy link
Owner

I was able to reproduce this issue, so looks like a bug, will take a look. Thanks!

@prymitive
Copy link
Owner

prymitive commented Mar 9, 2019

Looks like keys are always lowercase when config is loaded, so P1: foo becomes p1: foo.
Seems that the root cause is spf13/viper#260 and there is a PR open to address it - spf13/viper#635

@xingmin860818
Copy link
Author

Yes, I found PR can fix it, can this method be used in karma,or I modify my self,or I change the values to lowercase?

@prymitive
Copy link
Owner

There's no easy fix util that PR gets merged, but doesn't look like there's much activity on it from the viper maintainer.
I'll see if I can work around this issue in karma by doing case insensitive comparison of label values.

@xingmin860818
Copy link
Author

Thanks a lot, I will track the release note if you change it.

prymitive added a commit that referenced this issue Mar 13, 2019
This is a workaround until this issue is fixed upstream.

Fixes #507
prymitive added a commit that referenced this issue Mar 13, 2019
This is a workaround until this issue is fixed upstream.

Fixes #507
@prymitive
Copy link
Owner

I'll add a workaround via #516 while we wait for an upstream fix

@prymitive
Copy link
Owner

This should now work with the latest docker image

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants