-
-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More informative error extrapolation drive cycle #3612
Comments
Would |
For the drive cycle name? I would call it something like "Current drive cycle" (or power/voltage whatever drives it). |
@brosaplanella I want to work on this issue. Is it still open? |
@brosaplanella, I had worked on this but could not commit the changes due to a fault in my environment setup. |
Thanks @jeromtom |
At the moment, if a drive cycle starts at
t=1
rather thant=0
it throws a rather uninformative error (see below)The easiest way to address this would be:
PyBaMM/pybamm/experiment/step/_steps_util.py
Lines 123 to 125 in e0bec2b
t>0
throw a different, more specific error (or assume it's zero until first provided value, but I personally think this is dangerous).t=0
, added to Improve documentation (ongoing) #3392 already.The text was updated successfully, but these errors were encountered: