Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where to put Example notebooks that should not be part of the CI? #419

Open
pmrv opened this issue Jun 1, 2022 · 2 comments
Open

Where to put Example notebooks that should not be part of the CI? #419

pmrv opened this issue Jun 1, 2022 · 2 comments
Labels
documentation Improvements or additions to documentation question Further information is requested

Comments

@pmrv
Copy link
Contributor

pmrv commented Jun 1, 2022

I believe we talked about that before, but what did we agree on in the end? Should there be an extra directory for not run notebooks or should we not allow such notebooks because they end up being out-dated?

@pmrv pmrv added documentation Improvements or additions to documentation question Further information is requested labels Jun 1, 2022
@liamhuber
Copy link
Member

liamhuber commented Jun 6, 2022

I lean to the latter. Some compromise ideas:

  • in all such notebooks, at the top do a pyiron version check and either fail or issue a severe warning message
  • keep such notebooks in a separate "showcase" repo, and instead of including them in the repo, show static snapshots of the notebooks on the website
    • Gives people a tour of what is possible without the immediate suggestion that they should try executing this code
    • should still have a version check at the top so people can quickly see the output and know what version will run this code

Even so, if they're not CI'd I'd rather not have them at all. Definitely can have notebooks that only get tested on the "integration" flag, but this might already be the case (just on my phone atm so not easy to quickly verify).

Edit: proper markdown sub lists

@pmrv
Copy link
Contributor Author

pmrv commented Jun 15, 2022

This sparked by an example notebook @yury-lysogorskiy had put for the ACE code, which we cannot install in CI, so I think a "showcase" is probably a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants