New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Refactoring Windows ARM64 - CPU Detection Logic #270

Open

ozanMSFT opened this issue Dec 11, 2024 · 0 comments

Contributor

ozanMSFT commented Dec 11, 2024

Current source code supports some pre-defined chips by hardcoded definitions:

https://github.com/pytorch/cpuinfo/blob/main/src/arm/windows/init.c

Currently information is stored in:

woa_chip_info woa_chips[woa_chip_name_last]

It would be better to add capability to detect new chips without breaking existing implementation.

Otherwise, this will generate "Unknown CPU" warning/error message for the all undefined ARM64 chips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment