From 8113b518b696c19e5de828215f1d594ce7600407 Mon Sep 17 00:00:00 2001 From: Vincent Scavinner Date: Tue, 14 Nov 2023 16:07:47 +0100 Subject: [PATCH 1/2] feat: drop support for Node 16 --- .github/workflows/ci.yml | 8 ++++---- package.json | 2 +- test-app/package.json | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 179effe6..8283c97b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -23,7 +23,7 @@ jobs: uses: wyvox/action-setup-pnpm@v3 with: pnpm-version: 8.5.1 - node-version: 16.x + node-version: 18.x args: "--frozen-lockfile" - name: Lint run: pnpm lint @@ -41,7 +41,7 @@ jobs: uses: wyvox/action-setup-pnpm@v3 with: pnpm-version: 8.5.1 - node-version: 16.x + node-version: 18.x args: "--no-lockfile" - name: Run tests run: pnpm test @@ -72,7 +72,7 @@ jobs: uses: wyvox/action-setup-pnpm@v3 with: pnpm-version: 8.5.1 - node-version: 16.x + node-version: 18.x args: "--frozen-lockfile" - name: Run tests run: pnpm ember try:one ${{ matrix.ember-try-scenario }} --skip-cleanup @@ -99,7 +99,7 @@ jobs: uses: wyvox/action-setup-pnpm@v3 with: pnpm-version: 8.5.1 - node-version: 16.x + node-version: 18.x args: "--frozen-lockfile" - name: Update TS version on addon package run: pnpm add -D ${{ matrix.typescript-scenario }} diff --git a/package.json b/package.json index 119abc52..3c951f11 100644 --- a/package.json +++ b/package.json @@ -27,7 +27,7 @@ "release-it": "^15.11.0" }, "engines": { - "node": "16.* || >= 18" + "node": ">= 18" }, "volta": { "node": "18.14.2" diff --git a/test-app/package.json b/test-app/package.json index 51888788..7b6b0c56 100644 --- a/test-app/package.json +++ b/test-app/package.json @@ -84,7 +84,7 @@ "webpack": "5.88.2" }, "engines": { - "node": "16.* || >= 18" + "node": ">= 18" }, "ember": { "edition": "octane" From 454e9d795f3c867eea2d9b48c5aa66e6cf535394 Mon Sep 17 00:00:00 2001 From: Vincent Scavinner Date: Tue, 14 Nov 2023 16:07:57 +0100 Subject: [PATCH 2/2] doc: add Node compatibility information --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index a37ca0d5..a04fdc1e 100644 --- a/README.md +++ b/README.md @@ -86,7 +86,7 @@ npm install --save-dev ember-autofocus-modifier - Ember.js v3.28 or above - Ember CLI v3.28 or above -- Node.js v16 or above +- Node.js v18 or above - TypeScript v5.0 or above ## TypeScript usage