Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve load time by avoiding fetch of all helm apps on load #10434

Open
richard-cox opened this issue Feb 12, 2024 · 3 comments · May be fixed by #10435
Open

Improve load time by avoiding fetch of all helm apps on load #10434

richard-cox opened this issue Feb 12, 2024 · 3 comments · May be fixed by #10435
Assignees
@richard-cox
Labels
area/performance area/server-side-pagination kind/enhancement QA/manual-test Indicates issue requires manually testing size/0.5 Size Estimate 0.5
Milestone
v2.11.0

Comments

@richard-cox
Copy link
Member

  • shell/mixins/brand.js has a blocking request to fetch all upstream helm apps to find existence of two
  • this shouldn't take long, as usually there's not many apps
  • however we could improve initial load time and when scaling by using the new filtering param to only fetch results for the two charts
@richard-cox richard-cox added this to the v2.9.0 milestone Feb 12, 2024
@richard-cox richard-cox linked a pull request Feb 12, 2024 that will close this issue
Draft
7 tasks
@zube zube bot removed the [zube]: To Triage label Feb 20, 2024
@nwmac nwmac added the QA/manual-test Indicates issue requires manually testing label Mar 7, 2024
@richard-cox
Copy link
Member Author

Blocked given availability of vai cache backed filtering

@gaktive
Copy link
Member

gaktive commented Apr 25, 2024

@richard-cox is this still on track for 2.9.0? I know there's been some VAI progress but I don't know if this is addressed.

@richard-cox
Copy link
Member Author

richard-cox commented Apr 25, 2024 •
edited
Loading

There's a PR up. The feature could be added without the vai cache, but it would then impact backend performance.

The vai cache stuff i think is still on target for 2.9.0... however... it will be off by default. We'd need to discuss what milestone this gets marked as done in

@richard-cox richard-cox modified the milestones: v2.9.0, v2.10.0 Jun 5, 2024
@nwmac nwmac modified the milestones: v2.10.0, v2.11.0 Jul 4, 2024
@richard-cox richard-cox modified the milestones: v2.10.0, v2.11.0 Sep 19, 2024
@nwmac nwmac modified the milestones: v2.12.0, v2.11.0 Nov 1, 2024
@richard-cox richard-cox added the size/0.5 Size Estimate 0.5 label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richard-cox richard-cox

Labels
area/performance area/server-side-pagination kind/enhancement QA/manual-test Indicates issue requires manually testing size/0.5 Size Estimate 0.5
Projects
None yet
Milestone
v2.11.0
Development

Successfully merging a pull request may close this issue.

Fetch only specific csp adapter helm apps... instead of all helm apps richard-cox/dashboard
3 participants
@nwmac @gaktive @richard-cox