Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase security access with SSL #6789

Open
cnotv opened this issue Sep 1, 2022 · 10 comments · May be fixed by #7158
Open

Increase security access with SSL #6789

cnotv opened this issue Sep 1, 2022 · 10 comments · May be fixed by #7158
Labels
area/test Test (e2e and unit) kind/tech-debt Technical debt
Milestone

Comments

@cnotv
Copy link
Member

cnotv commented Sep 1, 2022

As continuation of #6677 we would like to change protocols to HTTPS to secure authentications and requests.

Changes will require to update, due CORS issues:

  • API requests, 4000
  • Static content, 9000 on MinIO server

Both cases can be corrected with nginx directives by mapping the port to a segment and update SorryCypress setup data as well.
The first seems to be possible using GRAPHQL_SCHEMA_URL.
The static data may require further investigation.

Note: It will be required to update the E2E script for CI to use HTTPS protocol when communicating with the director service.

Playground server: http://167.172.180.127/

@cnotv cnotv self-assigned this Sep 1, 2022
@cnotv cnotv added kind/tech-debt Technical debt size/2 Size Estimate 2 labels Sep 1, 2022
@cnotv cnotv added this to the v2.7.0 milestone Sep 1, 2022
@nwmac nwmac modified the milestones: v2.7.0, v2.7.1 Sep 19, 2022
@gaktive gaktive modified the milestones: v2.7.2, v2.7.1 Oct 5, 2022
@cnotv cnotv linked a pull request Oct 11, 2022 that will close this issue
@cnotv
Copy link
Member Author

cnotv commented Oct 11, 2022

The use of HTTPS protocol seems returning an error existing in an older version of Cypress.

RequestError: Error: write EPROTO 65300708884936:error:100000f7:SSL routines:OPENSSL_internal:WRONG_VERSION_NUMBER:../../third_party/boringssl/src/ssl/tls_record.cc:242:

https://github.com/rancher/dashboard/actions/runs/3228470912/jobs/5284610299#step:6:53

@cnotv
Copy link
Member Author

cnotv commented Oct 14, 2022

Since removing SSL is not solving the video upload issue, I'm playing around another cluster to verify which steps starts to block the videos.

@cnotv
Copy link
Member Author

cnotv commented Oct 14, 2022

New installation of Sorry Cypress allows upload of videos but access is now blocked on port 9000

Screenshot 2022-10-14 at 17 13 54

@cnotv
Copy link
Member Author

cnotv commented Oct 17, 2022

Some other weird issue worth mentioning, when trying to host everything locally I encountered some caching issues, where the server kept pointing to the previous defined env var.
Screenshot 2022-10-17 at 18 59 30

@cnotv
Copy link
Member Author

cnotv commented Oct 17, 2022

On localhost address the 403 for CORS issue with MongoDB seems to do not exists. This may probably be something related to different ports.

Screenshot 2022-10-17 at 19 03 53

@cnotv
Copy link
Member Author

cnotv commented Oct 17, 2022

Re-running local tests against DO with new Sorry-Cypress DO instance has now generated an accessible video and the errors prior 403 are now turned into 404 🤔

Screenshot 2022-10-17 at 19 13 11
Screenshot 2022-10-17 at 19 13 33

@cnotv
Copy link
Member Author

cnotv commented Oct 17, 2022

It seems like some global configuration for Digital Ocean have been changed 🤔

@cnotv
Copy link
Member Author

cnotv commented Oct 18, 2022

The issue in accessing the videos seems related to firewall and reverse proxy of the port 9000 in the MINIO configuration, as it returns http://167.172.180.127/minio:9000/ instead of http://167.172.180.127/minio/.

Also ANY firewall rule seems blocking video access, generating CORS issues.

@cnotv
Copy link
Member Author

cnotv commented Oct 18, 2022

Upload issue returning Nothing to Upload is 100% due SSL configuration and may require further investigation.

@cnotv
Copy link
Member Author

cnotv commented Oct 18, 2022

Removing credentials for MINIO and SSL seems to fix the issue.
Keeping the issue opened so we can eventually try to enable it another time.
Created separated issue to restore videos: #7214

@nwmac nwmac modified the milestones: v2.7.next1, v2.7.next2 Dec 16, 2022
@cnotv cnotv modified the milestones: v2.7.next2, v2.7.next3 May 16, 2023
@cnotv cnotv removed the size/2 Size Estimate 2 label May 16, 2023
@cnotv cnotv added the area/test Test (e2e and unit) label May 16, 2023
@nwmac nwmac modified the milestones: v2.7.next3, v2.7.next4 Jun 27, 2023
@nwmac nwmac modified the milestones: v2.8.0, v2.8.next1 Aug 15, 2023
@nwmac nwmac modified the milestones: v2.9.0, v2.9.x Feb 27, 2024
@gaktive gaktive modified the milestones: v2.9.x, v2.12.0 Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test Test (e2e and unit) kind/tech-debt Technical debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants