Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #9648

Closed
9 tasks done
gaktive opened this issue Sep 1, 2023 · 11 comments
Closed
9 tasks done

Update dependencies #9648

gaktive opened this issue Sep 1, 2023 · 11 comments
Assignees
Labels
area/vue3 Bugs and technical debts as outcome to the Vue3 migration dependencies Pull requests that update a dependency file Epic kind/tech-debt Technical debt priority/0 QA/None size/3 Size Estimate 3
Milestone

Comments

@gaktive
Copy link
Member

gaktive commented Sep 1, 2023

We have some packages to update on dashboard before we ship our next version.

We did get a PR from @pjbgf to do this but based on how our UI works, we need to split those updates into separate ones for easier work. #9439 for reference.

Some of these may require a Vue update, or depend on webpacks, which means we could look at those later. This could be coordinated with updating Vue libraries prior to Vue3.

@gaktive gaktive added [zube]: Backlog dependencies Pull requests that update a dependency file kind/tech-debt Technical debt priority/0 labels Sep 1, 2023
@gaktive gaktive added this to the v2.8.0 milestone Sep 1, 2023
@nwmac
Copy link
Member

nwmac commented Sep 6, 2023

Note: We need to look at each in tern - not all can be done at this time.

@gaktive
Copy link
Member Author

gaktive commented Sep 6, 2023

yarn why would help understand the dependencies' own dependencies. yarn audit can help too.

@gaktive
Copy link
Member Author

gaktive commented Sep 6, 2023

yarn upgrade-interactive --latest could also help too.

@richard-cox
Copy link
Member

I've updated those we can do given vue-cli and where where we are for this release (see confluence rancher / dashboard dependencies for a full write up). I'll make this in to an epic and split out the ones that are done

@richard-cox richard-cox changed the title Update dependencies for 2.8.0 Update dependencies Sep 25, 2023
@richard-cox richard-cox modified the milestones: v2.8.0, v2.8.next1 Sep 25, 2023
@richard-cox
Copy link
Member

I've jigged around the target milestone given what we're committed to

This was referenced Sep 25, 2023
@richard-cox
Copy link
Member

Linking dependent issue #7653. Until we bump vue (specifically vue-cli) we can't progress this. Moving to v2.8.next2 to check status of that vue3 migration in next release

@richard-cox richard-cox modified the milestones: v2.8.next1, v2.8.next2 Nov 23, 2023
@nwmac nwmac added the QA/None label Jan 30, 2024
@nwmac nwmac modified the milestones: v2.8.next2, v2.9.0 Feb 27, 2024
@richard-cox richard-cox removed this from the v2.9.0 milestone May 22, 2024
@richard-cox richard-cox added this to the v2.10.0 milestone May 22, 2024
@nwmac nwmac modified the milestones: v2.10.0, v2.11.0 Jul 4, 2024
@nwmac nwmac modified the milestones: v2.11.0, v2.10.0 Jul 16, 2024
@richard-cox richard-cox added the area/vue3 Bugs and technical debts as outcome to the Vue3 migration label Sep 19, 2024
@richard-cox
Copy link
Member

richard-cox commented Sep 19, 2024

Given the vue3 bump this can now be re-evaluated.

Removing assignment, anyone can pick this one up

@richard-cox richard-cox removed their assignment Sep 19, 2024
@rak-phillip
Copy link
Member

I'm checking off loader-utils for the following reasons

  1. This is a transitive dependency that is not explicitly declared as a dependency in dashboard
  2. loader-utils is at 1.4.2 as of writing this comment
yarn why loader-utils

yarn why v1.22.19
[1/4] Why do we have the module "loader-utils"...?
[2/4] Initialising dependency graph...
[3/4] Finding dependency...
[4/4] Calculating file sizes...
=> Found "[email protected]"
info Has been hoisted to "loader-utils"
info Reasons this module exists
   - "workspace-aggregator-7f68b920-9183-44c5-9a85-c1d73de0033e" depends on it
   - Hoisted from "_project_#cache-loader#loader-utils"
   - Hoisted from "_project_#js-yaml-loader#loader-utils"
   - Hoisted from "_project_#@vue#cli-service#vue-style-loader#loader-utils"
   - Hoisted from "_project_#@vue#cli-service#@vue#vue-loader-v15#loader-utils"
   - Hoisted from "_project_#@cypress#webpack-dev-server#html-webpack-plugin-4#loader-utils"
=> Found "csv-loader#[email protected]"
info This module exists because "_project_#csv-loader" depends on it.
=> Found "frontmatter-markdown-loader#[email protected]"
info This module exists because "_project_#frontmatter-markdown-loader" depends on it.
=> Found "worker-loader#[email protected]"
info This module exists because "_project_#worker-loader" depends on it.
=> Found "thread-loader#[email protected]"
info This module exists because "_project_#@vue#cli-service#thread-loader" depends on it.
=> Found "@vue/cli-plugin-babel#[email protected]"
info Reasons this module exists
   - "_project_#@rancher#components#@vue#cli-plugin-babel#babel-loader" depends on it
   - Hoisted from "_project_#@rancher#components#@vue#cli-plugin-babel#babel-loader#loader-utils"
=> Found "@vue/cli-plugin-typescript#[email protected]"
info Reasons this module exists
   - "_project_#@rancher#components#@vue#cli-plugin-typescript#babel-loader" depends on it
   - Hoisted from "_project_#@rancher#components#@vue#cli-plugin-typescript#babel-loader#loader-utils"
Done in 0.56s.

@rak-phillip
Copy link
Member

Marking word-wrap as completed. At this time, word-wrap is at 1.2.5. It is also a transitive dependency.

➤ yarn why word-wrap

yarn why v1.22.19
[1/4] Why do we have the module "word-wrap"...?
[2/4] Initialising dependency graph...
[3/4] Finding dependency...
[4/4] Calculating file sizes...
=> Found "[email protected]"
info Reasons this module exists
   - "_project_#eslint#optionator" depends on it
   - Hoisted from "_project_#eslint#optionator#word-wrap"
   - Hoisted from "_project_#browser-env#window#jsdom#escodegen#optionator#word-wrap"
info Disk size without dependencies: "24KB"
info Disk size with unique dependencies: "24KB"
info Disk size with transitive dependencies: "24KB"
info Number of shared dependencies: 0
Done in 0.62s.

@rak-phillip
Copy link
Member

Moving this to QA Review - all dependencies listed in the epic now satisfy their requirements.

@yonasberhe23
Copy link
Contributor

nothing for QA to do here. moving to done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vue3 Bugs and technical debts as outcome to the Vue3 migration dependencies Pull requests that update a dependency file Epic kind/tech-debt Technical debt priority/0 QA/None size/3 Size Estimate 3
Projects
None yet
Development

No branches or pull requests

5 participants