Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More helpers? #1

Open
ravener opened this issue Feb 15, 2021 · 2 comments
Open

More helpers? #1

ravener opened this issue Feb 15, 2021 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ravener
Copy link
Owner

ravener commented Feb 15, 2021

To anyone reading this, do you think we should add more helper methods to request discord api? Currently people only get an http client and do whatever they want but should we provide functions abstracting away the URL and stuff?

I just feel this project is way too light and would love to make it a bit more useful than this.

I'll leave this open until someone steps in and gives me some feedback

Additionally if someone could give me an idea on how should the interface be exposed? I'd imagine putting it in a subpackage so people can still use the basic provider if they don't need the advanced helpers.

@zivoy
Copy link

zivoy commented Mar 1, 2021

I think you should have the API calls be done in functions and handle all the errors, then have them return the json parsed for easier use.
also to make it so that you need fewer lines of code when implementing it, have everything be handled on this package side.

@ravener
Copy link
Owner Author

ravener commented Mar 6, 2021

I think you should have the API calls be done in functions and handle all the errors, then have them return the json parsed for easier use.
also to make it so that you need fewer lines of code when implementing it, have everything be handled on this package side.

Thank you for the reply, I'll try to design a better interface in a subpackage when I get the time.

@ravener ravener added enhancement New feature or request help wanted Extra attention is needed labels Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants