Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for user-selection of content across spread-boundaries #72

Open
rkwright opened this issue Jun 13, 2018 · 2 comments
Open

Support for user-selection of content across spread-boundaries #72

rkwright opened this issue Jun 13, 2018 · 2 comments
Assignees

Comments

@rkwright
Copy link
Contributor

This is a DISCUSSION.

Expected Behaviour

Users would like to be able to select text across a two-page spread.

Steps to reproduce

  1. Open an EPUB document with a two-page spread
  2. Verify that the two page spread is visible and each page is separately selectable.
  3. Try to select some text ACROSS the two pages (i.e. some text from each page)

Observed behaviour

Only text from one page can be selected

Test file(s)

Any EPUB with a two-page spread.

Product

*Any Readium-based software demonstrates this limitation

Additional information

None at this time

@JayPanoz
Copy link
Contributor

Pinging @SeldomScene as he had to deal with this issue and may provide useful insights – if he’s comfortable doing so, obviously.

@jccr
Copy link
Contributor

jccr commented Jun 13, 2018

I wish browsers would allow multiple selections to be made, it's in the spec and in the API.
https://developer.mozilla.org/en-US/docs/Web/API/Selection/rangeCount
window.getSelection().getRangeAt(1) window.getSelection().getRangeAt(2)

In FF you can hold Ctrl and make multiple non-continuous selections. In Chrome you can't.


I could see that concept being adopted for selections across iframes.
Implemented in a way that wouldn't have the user use Ctrl: Two selection ranges would be made on behalf of the user automatically.

It would be nice to have a selection API that's scoped to the whole publication without worrying about the different iframe window contexts. It makes things simpler, maybe if you can get past the security concerns. This is a supplementary idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants