Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💡 Feature request: allow setting of system theme for light and dark #299

Open
helmut72 opened this issue Oct 23, 2024 · 3 comments
Open
Labels
enhancement New feature or request

Comments

@helmut72
Copy link

Is your feature request related to a problem? Please describe.

I have problems reading red text on dark background. I have set redlib to use system theme to be in sync of my desktop and phone setting.

Describe the feature you would like to be implemented

Would be cool if light and dark theme can be set for system theme.

Describe alternatives you've considered

Don' use system theme and manually change theme regarding to my desktop or phone setting.

Additional context / screenshot

Thank you.

@helmut72 helmut72 added the enhancement New feature or request label Oct 23, 2024
@DokterKaj
Copy link
Contributor

Hey, not sure I really understand what's being requested here; can you elaborate in more detail?

If it's about customising the accent colour, I recommend using Stylus and adding something like this:

:root {
    --accent: <your dark colour>;
}

@media (prefers-color-scheme: light) {
    :root {
        --accent: <your light colour>;
        color-scheme: light;
    }
}

@helmut72
Copy link
Author

helmut72 commented Oct 23, 2024

I have set redlib to use system theme:

Bildschirmfoto 2024-10-23 um 20 59 10

Then, redlib automatically use theme "light" or theme "dark":

Bildschirmfoto 2024-10-23 um 21 08 02

... up to my phone/desktop setting.

But redlibs theme "dark" is red text on dark grey background. It's very hard for me to read this.

Therefore I want to ask for an option what light or dark theme redlib use when set to "system". For a dark theme I prefer "libredditBlack".

ENV variables like this would be great:

THEME_SYSTEM_LIGHT="libredditLight" 
THEME_SYSTEM_DARK="libredditBlack"

If THEME="system" is set, above themes should be used for the light and for the dark theme.

@Tech-How
Copy link

Tech-How commented Nov 1, 2024

Yeah I'd love to see this as well. Not sure why it was changed to red, but a separate "Default Dark Theme", and "Default Light Theme", would be appreciated. That way, the site would still switch between light and dark automatically, but we can control which light and dark theme it switches to. Adding simple options for text and background color would be amazing as well, instead of just the preset themes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants