Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reown 1.2.* conflict and reown 1.1.1 #83

Open
factblock-roy opened this issue Jan 23, 2025 · 2 comments
Open

reown 1.2.* conflict and reown 1.1.1 #83

factblock-roy opened this issue Jan 23, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@factblock-roy
Copy link

Describe the bug
A clear and concise description of what the bug is.

SDK Version

  • Client: [e.g. Swift]
  • Version [e.g. 22] 1.2.*

To Reproduce
Steps to reproduce the behavior:

  1. install metamask-ios-sdk 0.8.10 and reown 1.2.* then build and run
    show multiple commands issue. so couldn`t install 1.2.*

  2. reown 1.1.1 why not working recommendedWalletIds its my appkit configure

AppKit.configure(
projectId: Bundle.main.object(forInfoDictionaryKey: "WALLET_CONNECT_PROJECT_ID") as! String,
metadata: metadata,
crypto: DefaultCryptoProvider(),
authRequestParams: nil,
includeWebWallets: false,
recommendedWalletIds: [
WalletId.Metamask,
WalletId.Burrito,
WalletId.TrustWallet,
WalletId.Rainbow,
WalletId.Zerion,
WalletId.Phantom,
],
coinbaseEnabled: false
)

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Device (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@factblock-roy factblock-roy added the bug Something isn't working label Jan 23, 2025
Copy link

linear bot commented Jan 23, 2025

@factblock-roy
Copy link
Author

i analyze package but recommendedWalletIds is not used anywhere

i think try? await w3mApiInteractor.fetchWalletImages(for: store.recentWallets + store.customWallets) this line recommendWallets need bind

`public static func configure(
projectId: String,
metadata: AppMetadata,
crypto: CryptoProvider,
sessionParams: SessionParams = .default,
authRequestParams: AuthRequestParams?,
includeWebWallets: Bool = true,
recommendedWalletIds: [String] = [],
excludedWalletIds: [String] = [],
customWallets: [Wallet] = [],
coinbaseEnabled: Bool = true,
onError: @escaping (Error) -> Void = { _ in }
) {
Pair.configure(metadata: metadata)

    AppKit.config = AppKit.Config(
        projectId: projectId,
        metadata: metadata,
        crypto: crypto,
        sessionParams: sessionParams,
        authRequestParams: authRequestParams,
        includeWebWallets: includeWebWallets,
        recommendedWalletIds: recommendedWalletIds,
        excludedWalletIds: excludedWalletIds,
        customWallets: customWallets,
        coinbaseEnabled: coinbaseEnabled,
        onError: onError
    )

    Sign.configure(crypto: crypto)

    let store = Store.shared
    let router = Router()
    let w3mApiInteractor = W3MAPIInteractor(store: store)
    let signInteractor = SignInteractor(store: store)
    let blockchainApiInteractor = BlockchainAPIInteractor(store: store)
    
    store.customWallets = customWallets
    
    configureCoinbaseIfNeeded(
        store: store,
        metadata: metadata,
        w3mApiInteractor: w3mApiInteractor
    )
    
    AppKit.viewModel = Web3ModalViewModel(
        router: router,
        store: store,
        w3mApiInteractor: w3mApiInteractor,
        signInteractor: signInteractor,
        blockchainApiInteractor: blockchainApiInteractor,
        supportsAuthenticatedSession: (config.authRequestParams != nil)
    )
    
    Task {
        try? await w3mApiInteractor.fetchWalletImages(for: store.recentWallets + store.customWallets)
        try? await w3mApiInteractor.fetchAllWalletMetadata()
        try? await w3mApiInteractor.fetchFeaturedWallets()
        try? await w3mApiInteractor.prefetchChainImages()
    }
}
`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant