Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong type for Batch response #72

Closed
yehuda-margolis opened this issue Apr 17, 2024 · 2 comments
Closed

Wrong type for Batch response #72

yehuda-margolis opened this issue Apr 17, 2024 · 2 comments

Comments

@yehuda-margolis
Copy link

) -> List[Dict]:

Seems like the typing here is wrong...
The response is actually in this format ->

{
  "data": [
    {
      "id": "ae2014de-c168-4c61-8267-70d2662a1ce1"
    },
    {
      "id": "faccb7a5-8a28-4e9a-ac64-8da1cc3bc1cb"
    }
  ]
}

should be Dict[str, Dict]

@drish
Copy link
Collaborator

drish commented Apr 17, 2024

@yehuda-margolis thanks for opening the ticket, we're doing an entire type hinting revamp for the next sdk major release, which should be live soon: #71

@drish
Copy link
Collaborator

drish commented May 9, 2024

v1.0.0 has been released

@drish drish closed this as completed May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants