Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Support creation of BOE against more than one purchase invoice #2932

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

fix: Support creation of BOE against more than one purchase invoice #2932

wants to merge 6 commits into from

Conversation

Sanket322
Copy link
Contributor

@Sanket322 Sanket322 commented Jan 8, 2025 •
edited by huly-for-github bot
Loading

@Sanket322 Sanket322 marked this pull request as draft January 8, 2025 06:10
@codecov Codecov
Copy link

codecov bot commented Jan 8, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 60.97561% with 32 lines in your changes missing coverage. Please review.

Project coverage is 59.99%. Comparing base (49ed725) to head (83152b4).
Report is 16 commits behind head on develop.

Files with missing lines Patch % Lines
...e/gst_india/doctype/bill_of_entry/bill_of_entry.py 57.89% 32 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2932      +/-   ##
===========================================
- Coverage    60.04%   59.99%   -0.06%     
===========================================
  Files          122      123       +1     
  Lines        12102    12157      +55     
===========================================
+ Hits          7267     7293      +26     
- Misses        4835     4864      +29
Files with missing lines Coverage Δ
...ctype/boe_purchase_invoice/boe_purchase_invoice.py 100.00% <100.00%> (ø)
...a/doctype/purchase_reconciliation_tool/__init__.py 82.95% <100.00%> (+0.03%) ⬆️
...a_compliance/gst_india/overrides/ineligible_itc.py 95.81% <100.00%> (+0.01%) ⬆️
...e/gst_india/doctype/bill_of_entry/bill_of_entry.py 75.93% <57.89%> (-2.51%) ⬇️

... and 8 files with indirect coverage changes

Impacted file tree graph

@Sanket322 Sanket322 marked this pull request as ready for review January 10, 2025 11:37
@Sanket322 Sanket322 requested a review from vorasmit January 10, 2025 11:37
@vorasmit vorasmit added the p1 label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vorasmit vorasmit Awaiting requested review from vorasmit

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support creation of BOE against more than one purchase invoice
2 participants
@Sanket322 @vorasmit