Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

residual_resample issue #290

Open
siyangsong opened this issue Aug 16, 2023 · 0 comments
Open

residual_resample issue #290

siyangsong opened this issue Aug 16, 2023 · 0 comments

Comments

@siyangsong
Copy link

siyangsong commented Aug 16, 2023 •
edited
Loading

I noticed the definition of the residual in residual resampling should be

residual = N*weights - num_copies

while the current code has

https://github.com/rlabbe/filterpy/blob/3b51149ebcff0401ff1e10bf08ffca7b6bbc4a33/filterpy/monte_carlo/resampling.py#L70C1-L70C62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@siyangsong