Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websocket RPC pitfalls #13

Open
hobofan opened this issue Oct 4, 2018 · 1 comment
Open

Websocket RPC pitfalls #13

hobofan opened this issue Oct 4, 2018 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@hobofan
Copy link
Member

hobofan commented Oct 4, 2018

#12 added the websocket RPC, but there are some caveats with it:

  • Only one subscription per connection right now. Not sure how much impact that actually has with most clients, but should be resolved sooner or later.
  • Doubt if the way we consume the stream is the proper way to do it:
    Ok(Async::NotReady) => thread::sleep(time::Duration::from_millis(100)),

    For now it works well enough as it consumes all outstanding entities as fast as it can, but it introduces a delay of up to 100ms for any incoming entities
@hobofan hobofan added bug Something isn't working enhancement New feature or request labels Oct 4, 2018
@hobofan
Copy link
Member Author

hobofan commented Oct 8, 2018

  • I think the websocket future streams also don't finish correctly when a websocket connection is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant