Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag conflict causes tags to always be rewritten #43

Open
djjeck opened this issue Jan 5, 2015 · 3 comments
Open

Tag conflict causes tags to always be rewritten #43

djjeck opened this issue Jan 5, 2015 · 3 comments

Comments

@djjeck
Copy link

djjeck commented Jan 5, 2015

I noticed that when ALBUMARTIST tag is set, but not BAND, since they are both mapped to the same key (TPE2), they overwrite each other, causing the tag matching to fail and the tags to be rewritten on subsequent re-runs.
This is not always the case, but it looks like it happens with 50% probability. It looks like no precedence is declared between the two, so I guess it depends on how python iterates the map structures involved.
(A similar thing happens for the COMMENT tag, but I believe it happens because of a multiple comment field that I will manually fix. This is much rarer, just one album on my collection. I'm not sure the file is well-formed, so I won't open another ticket)

Workaround: get rid of the BAND tag. I actually remember that ALBUMARTIST was commented out some time ago, possibly for this reason. But if one needs to go, I'd take BAND out.
Replacing

'BAND'                    => 'TPE2',

with

'BAND'                    => 'TXXX',

stops the tag rewrites from happening.

I will try to implement a better fix, with no indeterminacy nor information loss involved, and update this thread.

@andynormancx
Copy link

Did you come up with a better fix ? I've just run into this issue.

@TheGoblinHero
Copy link

Fix works. Thx!

@trip5
Copy link

trip5 commented Dec 31, 2019

Yeah I just commented out that line completely. I've never seen a BAND tag used anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants