Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add emplace_back functions #32

Open
Nicogene opened this issue Jan 13, 2021 · 2 comments
Open

Add emplace_back functions #32

Nicogene opened this issue Jan 13, 2021 · 2 comments
Assignees
@AlexAntn @Nicogene
Labels
enhancement New feature or request

Comments

@Nicogene
Copy link
Member

Alongside the push_back functions we should implement the emplace_back, both in Buffer and BufferManager
@Nicogene Nicogene added the enhancement New feature or request label Jan 13, 2021
@Nicogene
Copy link
Member Author

Adding this feature may not be as trivial as I thought if we are going to use the boost::circular_buffer

This feature seems to be still missing see https://svn.boost.org/trac10/ticket/9299#no1 and boostorg/circular_buffer#15

@AlexAntn
Copy link
Contributor

Do we need that feature though? Considering it is not present also in the circular buffer, it is likely we won't have a use for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexAntn AlexAntn

@Nicogene Nicogene

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlexAntn @Nicogene