Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request MBR Header/TF Frame #1

Open
valschmidt opened this issue Feb 9, 2022 · 1 comment
Open

Feature Request MBR Header/TF Frame #1

valschmidt opened this issue Feb 9, 2022 · 1 comment

Comments

@valschmidt
Copy link

This feature request is to add to the MBR node the ability to configure the antenna's installation offsets relative to the "base_link" of the platform, and to capture these in the MBR header frame_id field.

Rational: Within the MBR log data are the range, azimuth and declination wrt the antenna base of the beam formed by the radio during the last time cycle. Configuring these things in the node should allow us to use the TF tree to calculate the these fields wrt the map frame. Knowing this will help inform modeling of this system performance both in real time and in post-mortem.

Follow on: Using the configured frame_id and TF calculate the azimuth and declination between antennas in the map frame and publish this on a topic.

@rolker
Copy link
Owner

rolker commented Feb 9, 2022

Good idea!

To get the frame_id field, we'll need to create a message type with a header, since we are now using standard floats without a header.

We can start by creating a new message type, and supporting both floats and the new type as we test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants