You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We consolidate all logs to Datadog for analysis, this requires formats to be ingestible and there are no secrets/personal information in logs
In testing rk-boot, any environment or flag based config overrides are always logged out as an info log, this exposes any secrets being pushed down from the environment
LoggerEntryStdout.Info("Found ENV to override, applying...", zapFields...)
At the very least this should be a dev only level log.
They also ignore any Zap log configs as they are shipped before the log configuration is parsed. This is good during failures so the config can be diagnosed but bad as it breaks standardised parsing. This would be less of an issue if they weren't created in non-development environments.
The text was updated successfully, but these errors were encountered:
We consolidate all logs to Datadog for analysis, this requires formats to be ingestible and there are no secrets/personal information in logs
In testing rk-boot, any environment or flag based config overrides are always logged out as an info log, this exposes any secrets being pushed down from the environment
rk-entry/entry/util.go
Line 352 in fb17205
At the very least this should be a dev only level log.
They also ignore any Zap log configs as they are shipped before the log configuration is parsed. This is good during failures so the config can be diagnosed but bad as it breaks standardised parsing. This would be less of an issue if they weren't created in non-development environments.
The text was updated successfully, but these errors were encountered: