Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: PackageDownloader::download() method does not indicate all download errors #1926

Open
m-blaha opened this issue Dec 4, 2024 · 0 comments
Labels
Priority: MEDIUM Triaged Someone on the DNF 5 team has read the issue and determined the next steps to take

Comments

@m-blaha
Copy link
Member

m-blaha commented Dec 4, 2024

The PackageDownloader::download() method throws an exception only in the case of "irrecoverable" download errors. When the fail_fast flag is set to false, the method does not throw an error even if some targets fail to download. Errors related to individual downloads are reported exclusively via the corresponding librepo targets. Since these librepo targets are stored as local variables within the method, the caller of download() cannot check the status of individual downloads.

This behavior impacts reposync, which is expected to:

  • Avoid failing on the first error, downloading as many packages as possible (hence, fail_fast is set to false).
  • Return an exit code of 1 if some packages fail to download (now the API does not provide way how to check it)
@ppisar ppisar added Priority: MEDIUM Triaged Someone on the DNF 5 team has read the issue and determined the next steps to take labels Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: MEDIUM Triaged Someone on the DNF 5 team has read the issue and determined the next steps to take
Projects
None yet
Development

No branches or pull requests

2 participants