Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPRECATE: Ability to send arbitrary messages to all peers #34

Open
DamonOehlman opened this issue Mar 12, 2015 · 0 comments
Open

DEPRECATE: Ability to send arbitrary messages to all peers #34

DamonOehlman opened this issue Mar 12, 2015 · 0 comments
Assignees

Comments

@DamonOehlman
Copy link
Member

To ensure compatibility with distributed variants of switchboard and to help manage guarantees of message delivery, we are deprecating the following functionality:

  • The ability to send a broadcast commands to all other signallers connected to a room, which means that the only broadcast message type we are attempting to ensure delivery of is the /announce message.
  • The ability to send random text to other participants in the room, triggering a data event on the remote signallers.

It will still be completely possible to send targeted commands to known peers through the use of to messages (i.e. signaller.to(targetId).send('/foobar')), but the future of arbitrary data is being reconsidered as part of this issue. As such it is advisable to reconsider any use that you may have made of the data event on the signaller.

After working with signaller for and building apps using both quickconnect and signaller, I have rarely used the feature (and arguably only ever abused it) so for the sake of a more solid implementation this should be removed.

@DamonOehlman DamonOehlman self-assigned this Mar 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant