Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Memchr not compatible with no_std (since 834d442) #514

Closed
CWood1 opened this issue May 19, 2017 · 5 comments
Closed

Regression: Memchr not compatible with no_std (since 834d442) #514

CWood1 opened this issue May 19, 2017 · 5 comments

Comments

@CWood1
Copy link
Contributor

CWood1 commented May 19, 2017

Memchr relies on libc, which is not available in a no_std context. The result is the following error:

error[E0463]: can't find crate for `std`
  |
  = note: the `x86_64-unknown-none` target may not be installed

error: aborting due to previous error

error: Could not compile `libc`.
@Geal
Copy link
Collaborator

Geal commented May 19, 2017

try to compile with `default-features = false" ?

@CWood1
Copy link
Contributor Author

CWood1 commented May 19, 2017

I attempted to compile nom with default-features = false, unfortunately I don't believe there's a way to influence the libc compilation. If I go one commit before, it works perfectly, though does indeed give the same error if I re-enable default-features.

@Geal
Copy link
Collaborator

Geal commented May 21, 2017

I think with rust-lang/cargo#712 (original idea here rust-lang/cargo#633 (comment) ) it can be achievable.
I probably won't have the time to test this until thursday, would you be willing to test and make a patch for it?

@CWood1
Copy link
Contributor Author

CWood1 commented May 21, 2017

Sure, I'll take a look into that over the next day or two. Thanks for your help, I'll report back here after my investigations.

@Geal
Copy link
Collaborator

Geal commented Jun 16, 2017

your fix is released in nom 3.1, thank you for your help!

@Geal Geal closed this as completed Jun 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants