Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip buffered rows rendering on long scroll #397

Open
rtrg opened this issue Feb 20, 2019 · 2 comments
Open

Skip buffered rows rendering on long scroll #397

rtrg opened this issue Feb 20, 2019 · 2 comments

Comments

@rtrg
Copy link
Contributor

rtrg commented Feb 20, 2019

Expected Behavior

Scroll bar shouldn't lag behind mouse pointer
correct

Current Behavior

When I scroll from top to down using scroll bar (for 1000 rows), buffered rows is getting rendered ~7 times, even with allowCellsRecycling and pureRendering, scroll bar lags behind mouse pointer.

wrong

Possible Solution

When scrolling is in progress and scroll length is greater than some threshold (ex: number of visible rows height) don't render buffered rows and just return empty div in FixedDataTableBufferedRows (gif in expected behavior is generated with similar change) until scroll is stopped

Your Environment

  • Version used:
    "fixed-data-table-2": "^1.0.0-beta.12"
@wcjordan
Copy link
Member

I'd consider a PR for this.

@wcjordan
Copy link
Member

Hey @rtrg now that we're revamping the scrollbar API and should be able to support native scroll, do you have any ideas for what we can do to improve this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants