Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

models actually not sorted #4

Open
st opened this issue Sep 14, 2023 · 2 comments
Open

models actually not sorted #4

st opened this issue Sep 14, 2023 · 2 comments

Comments

@st
Copy link

st commented Sep 14, 2023

Hello,

This line sorts by the key :mean in a thread-last operator.

But the given sequence contains maps keyed by :model :metric and :fit-ctx
Isn't the sort useless?
Shouldn't we use :metric instead?

@behrica
Copy link
Member

behrica commented Sep 14, 2023

Thanks for spotting this.
In practice here

we only get a single evaluation result back, the best. This is default behaviour of function evaluate-pipelines.
So sorting and reverting of a sequence of length one is not needed.

I will adapt the code accordingly and commit soon.

@st
Copy link
Author

st commented Sep 16, 2023

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants