Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary use of Flow #26

Open
TheLukaszNs opened this issue Nov 3, 2018 · 3 comments
Open

Unnecessary use of Flow #26

TheLukaszNs opened this issue Nov 3, 2018 · 3 comments

Comments

@TheLukaszNs
Copy link

In the Massa javascript source files, we are using @flow syntax to use Flow to check the static types, but we are not really using any of its possibilities (the only real use is in the SampleText.js file).
We either should use the Flow static type checking or (I don't recommend this way) delete the @flow comments.


Flow is a really good static type checker, why don't we use it to avoid all the bugs that we can possibly make?

@JaDogg
Copy link
Collaborator

JaDogg commented Dec 20, 2018

@TheLukaszNs would you like to send a pull request?

@TheLukaszNs
Copy link
Author

@JaDogg Sure, I'll work on that

@JaDogg
Copy link
Collaborator

JaDogg commented Dec 20, 2018

@TheLukaszNs Thanks. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants