Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Added nlopez compose rules for ktlint and detekt #242

Conversation

angrezichatterbox
Copy link
Member

Contributor checklist


Description

The pull request adds the nlopez Compose rules to the ktlint and detekt tasks to check for linting issues. It also corrects the existing linting issues that were detected. Additionally, Slack Compose rules have been added to the lint checks, ensuring that the IDE can detect any linting issues and provide recommendations for better practices.

Related issue

Copy link

github-actions bot commented Nov 14, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@angrezichatterbox
Copy link
Member Author

Some linting issues were detected after running the ./gradlew lint command. However, these issues are related to XML files and can be addressed later, once the Jetpack Compose migration is complete. :)

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All's working great here, @angrezichatterbox 😊 Thanks for devising this and getting to it so quickly! 🚀

@andrewtavis andrewtavis merged commit 8ca79dd into scribe-org:main Nov 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants