Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MFP algorithm lengthens overlapping notes at tail end of files #110

Open
NyuBlara opened this issue Oct 30, 2024 · 0 comments
Open

MFP algorithm lengthens overlapping notes at tail end of files #110

NyuBlara opened this issue Oct 30, 2024 · 0 comments
Labels
bug Something isn't working MFP lib Regarding lib-midifile-performer, not the app itself

Comments

@NyuBlara
Copy link
Collaborator

Take the last measure of Dvorak's silhouette n°4 (op08n04.zip) :

image

The dotted half-note should end before the fermata-bearing half-note chords that closes the piece (a fermata is interpreted as multiplying duration by 2).

However, this is the same measure as viewed in the piano roll.

image

This is because the last two sets of the piece are the end set of the dotted half-note followed by that of the fermata chords :

image

And thus, they are merged by the MFP lib, and the dotted note lasts longer.

@NyuBlara NyuBlara added bug Something isn't working MFP lib Regarding lib-midifile-performer, not the app itself labels Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working MFP lib Regarding lib-midifile-performer, not the app itself
Projects
None yet
Development

No branches or pull requests

1 participant