Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why does the IOCTL's "allNotesOff" method send individual 0x80 bytes for every pitch instead of the all notes off message ? #121

Open
NyuBlara opened this issue Nov 11, 2024 · 1 comment
Open

Why does the IOCTL's "allNotesOff" method send individual 0x80 bytes for every pitch instead of the all notes off message ? #121

NyuBlara opened this issue Nov 11, 2024 · 1 comment
Labels
question Further information is requested

Comments

@NyuBlara
Copy link
Collaborator

The expected behavior (sending all notes off/all sound off) is actually found in the IOCTL code, but is commented out. Individual note offs are sent instead.

image

This has actually been the case since the first-ever commit of the IOCTL.

Is there a reason for this ?
@NyuBlara NyuBlara added the question Further information is requested label Nov 11, 2024
NyuBlara added a commit that referenced this issue Nov 11, 2024
@NyuBlara
Fix notes hanging on channel mute
c1f78ee 
Separate silencing channel into its own method. Have one for the IOCTL 
and the sampler.

Open question issue #121 about a puzzling bit of commented code.

Misc : safe calls on currentChannelNotes required in synth for this to 
work. This is strange.
@josephlarralde
Copy link
Collaborator

I should have commented this more. I think this might be because at the time I found some (maybe old) virtual instruments that didn't support the all notes off message ... we might add a configuration flag enabling all notes off message by default but still allowing the current behavior. Anyway this has to be tested because the actual code might have been written due to some other limitation or specificity of MFP (despite I fail to remember which one).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@josephlarralde @NyuBlara