Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change autoplay color palette to simply lower opacity #150

Open
NyuBlara opened this issue Dec 11, 2024 · 0 comments
Open

Change autoplay color palette to simply lower opacity #150

NyuBlara opened this issue Dec 11, 2024 · 0 comments
Labels
improvement Something suboptimal to make better

Comments

@NyuBlara
Copy link
Collaborator

Lower opacity for velocity in the piano roll, inherited from Magenta, is not super useful for our app. Meanwhile, bright yellow for autoplay is not ergonomically viable.

The solution to this appears to be to universally associate lower opacity with autoplay.

For the sheet music, very low opacity will also be used for muted channels, so the two opacities levels will be different. For the piano roll, muted notes will still be outlined.
@NyuBlara NyuBlara added the improvement Something suboptimal to make better label Dec 11, 2024
NyuBlara added a commit that referenced this issue Dec 16, 2024
@NyuBlara
Change autoplay visual cues from yellow to more transparent (#150)
3a068fe 
This involves the following changes : 

- In the PianoRoll, velocity no longer affects note opacities. Only the 
note being autoplayed does.
- In SheetMusic, there are different opacity levels for autoplay, mute, 
and autoplay + mute.
- Contrast has been augmented, where necessary, to help with seeing the 
fainter colors.

Still, I am under the impression that this version is much less 
accessible than the previous one.
NyuBlara added a commit that referenced this issue Dec 17, 2024
@NyuBlara
Change autoplay visual cues from yellow to more transparent (#150)
a7dbed9 
This involves the following changes :

- In the PianoRoll, velocity no longer affects note opacities. Only the
note being autoplayed does.
- In SheetMusic, there are different opacity levels for autoplay, mute,
and autoplay + mute.
- Contrast has been augmented, where necessary, to help with seeing the
fainter colors.

Still, I am under the impression that this version is much less
accessible than the previous one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement Something suboptimal to make better
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NyuBlara