Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken search results on the website #2763

Closed
3 tasks done
VladimirShitov opened this issue Nov 23, 2023 · 1 comment · Fixed by #2805
Closed
3 tasks done

Broken search results on the website #2763

VladimirShitov opened this issue Nov 23, 2023 · 1 comment · Fixed by #2805

Comments

@VladimirShitov
Copy link

VladimirShitov commented Nov 23, 2023

Please make sure these conditions are met

  • I have checked that this issue has not already been reported.
  • I have confirmed this bug exists on the latest version of scanpy.
  • (optional) I have confirmed this bug exists on the master branch of scanpy.

What happened?

When you print something in the search bar on the documentation website, sometimes suggested links are broken. See the example for sc.pl.umap below.

Using google, I was able to find a correct page. Here is the correct and the broken link:

The difference is in latest/stable part. I tried searching for other functions as well, but did not notice any pattern. Here are some other links from search suggestion that are broken:

And a related issue. Why doesn't scanpy have a custom 404 page? 😄

Minimal code sample

Here's an example with looking for umap plot:

  • Search suggests a page:
image
  • First link (to the tool) is correct, but by clicking on the second one (for plotting) user gets 404:
image

Error output

No response

Versions

I was at the "stable" version on the website. Current scanpy version is 1.9.6

@flying-sheep
Copy link
Member

flying-sheep commented Nov 24, 2023

In #2220, DocSearch was removed from the latest docs.

Our current theme would probably support it, so we could re-introduce it (pydata/pydata-sphinx-theme#795). @ivirshup how do I get access to our DocSearch account?

PS: There’s more discussion about search plugins supported by our theme here: pydata/pydata-sphinx-theme#202

@flying-sheep flying-sheep linked a pull request Jan 25, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants