Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BugSplat Crash: SecondLifeViewer!LLFolderViewFolder::updateHasFavorites(1835) #3374

Open
sl-service-account opened this issue Jan 9, 2025 · 2 comments · Fixed by #3381
Open

BugSplat Crash: SecondLifeViewer!LLFolderViewFolder::updateHasFavorites(1835) #3374

sl-service-account opened this issue Jan 9, 2025 · 2 comments · Fixed by #3381
Assignees
@akleshchev
Labels
bugsplat maint-pe Issues for Maint releases / Product Engine team:viewer
Milestone
Maintenance C

Comments

@sl-service-account
Copy link

BugSplat Key Crash 98047

Sample Version:
7.1.12.12258017789

Sample Callstack:

SecondLifeViewer!LLFolderViewFolder::updateHasFavoritesC:/a/viewer/viewer/indra/llui/llfolderviewitem.cpp(1835)
SecondLifeViewer!LLInventoryPanel::itemChangedC:/a/viewer/viewer/indra/newview/llinventorypanel.cpp(766)
SecondLifeViewer!LLInventoryFavoritesItemsPanel::itemChangedC:/a/viewer/viewer/indra/newview/llinventorypanel.cpp(2482)
SecondLifeViewer!LLInventoryPanel::modelChangedC:/a/viewer/viewer/indra/newview/llinventorypanel.cpp(787)
SecondLifeViewer!LLInventoryPanelObserver::changedC:/a/viewer/viewer/indra/newview/llinventorypanel.cpp(94)
SecondLifeViewer!LLInventoryModel::notifyObserversC:/a/viewer/viewer/indra/newview/llinventorymodel.cpp(2157)
SecondLifeViewer!LLInventoryModel::changeItemParentC:/a/viewer/viewer/indra/newview/llinventorymodel.cpp(1755)
SecondLifeViewer!LLInvFVBridge::changeItemParentC:/a/viewer/viewer/indra/newview/llinventorybridge.cpp(1403)
SecondLifeViewer!LLFolderBridge::dragItemIntoFolderC:/a/viewer/viewer/indra/newview/llinventorybridge.cpp(5708)
SecondLifeViewer!LLFolderBridge::dragOrDropC:/a/viewer/viewer/indra/newview/llinventorybridge.cpp(4830)
SecondLifeViewer!LLFolderViewFolder::handleDragAndDropToThisFolderC:/a/viewer/viewer/indra/llui/llfolderviewitem.cpp(2212)
SecondLifeViewer!LLFolderViewFolder::handleDragAndDropC:/a/viewer/viewer/indra/llui/llfolderviewitem.cpp(2192)
SecondLifeViewer!LLView::childrenHandleDragAndDropC:/a/viewer/viewer/indra/llui/llview.cpp(833)
SecondLifeViewer!LLFolderViewFolder::handleDragAndDropC:/a/viewer/viewer/indra/llui/llfolderviewitem.cpp(2188)
SecondLifeViewer!LLView::childrenHandleDragAndDropC:/a/viewer/viewer/indra/llui/llview.cpp(833)
SecondLifeViewer!LLView::handleDragAndDropC:/a/viewer/viewer/indra/llui/llview.cpp(1095)
SecondLifeViewer!LLFolderView::handleDragAndDropC:/a/viewer/viewer/indra/llui/llfolderview.cpp(1600)
SecondLifeViewer!LLView::childrenHandleDragAndDropC:/a/viewer/viewer/indra/llui/llview.cpp(833)
SecondLifeViewer!LLScrollContainer::handleDragAndDropC:/a/viewer/viewer/indra/llui/llscrollcontainer.cpp(334)
SecondLifeViewer!LLView::childrenHandleDragAndDropC:/a/viewer/viewer/indra/llui/llview.cpp(833)
SecondLifeViewer!LLView::handleDragAndDropC:/a/viewer/viewer/indra/llui/llview.cpp(1095)
SecondLifeViewer!LLInventoryPanel::handleDragAndDropC:/a/viewer/viewer/indra/newview/llinventorypanel.cpp(1482)
SecondLifeViewer!LLView::childrenHandleDragAndDropC:/a/viewer/viewer/indra/llui/llview.cpp(833)
SecondLifeViewer!LLView::handleDragAndDropC:/a/viewer/viewer/indra/llui/llview.cpp(1095)
SecondLifeViewer!LLView::childrenHandleDragAndDropC:/a/viewer/viewer/indra/llui/llview.cpp(833)
SecondLifeViewer!LLView::handleDragAndDropC:/a/viewer/viewer/indra/llui/llview.cpp(1095)
SecondLifeViewer!LLView::childrenHandleDragAndDropC:/a/viewer/viewer/indra/llui/llview.cpp(833)
SecondLifeViewer!LLView::handleDragAndDropC:/a/viewer/viewer/indra/llui/llview.cpp(1095)
SecondLifeViewer!LLView::childrenHandleDragAndDropC:/a/viewer/viewer/indra/llui/llview.cpp(833)
SecondLifeViewer!LLView::handleDragAndDropC:/a/viewer/viewer/indra/llui/llview.cpp(1095)
SecondLifeViewer!LLView::childrenHandleDragAndDropC:/a/viewer/viewer/indra/llui/llview.cpp(833)
SecondLifeViewer!LLView::handleDragAndDropC:/a/viewer/viewer/indra/llui/llview.cpp(1095)
SecondLifeViewer!LLView::childrenHandleDragAndDropC:/a/viewer/viewer/indra/llui/llview.cpp(833)
SecondLifeViewer!LLView::handleDragAndDropC:/a/viewer/viewer/indra/llui/llview.cpp(1095)
SecondLifeViewer!LLView::childrenHandleDragAndDropC:/a/viewer/viewer/indra/llui/llview.cpp(833)
SecondLifeViewer!LLView::handleDragAndDropC:/a/viewer/viewer/indra/llui/llview.cpp(1095)
SecondLifeViewer!LLView::childrenHandleDragAndDropC:/a/viewer/viewer/indra/llui/llview.cpp(833)
SecondLifeViewer!LLView::handleDragAndDropC:/a/viewer/viewer/indra/llui/llview.cpp(1095)
SecondLifeViewer!LLView::childrenHandleDragAndDropC:/a/viewer/viewer/indra/llui/llview.cpp(833)
SecondLifeViewer!LLView::handleDragAndDropC:/a/viewer/viewer/indra/llui/llview.cpp(1095)
SecondLifeViewer!LLView::childrenHandleDragAndDropC:/a/viewer/viewer/indra/llui/llview.cpp(833)
SecondLifeViewer!LLView::handleDragAndDropC:/a/viewer/viewer/indra/llui/llview.cpp(1095)
SecondLifeViewer!LLView::childrenHandleDragAndDropC:/a/viewer/viewer/indra/llui/llview.cpp(833)
SecondLifeViewer!LLView::handleDragAndDropC:/a/viewer/viewer/indra/llui/llview.cpp(1095)
SecondLifeViewer!LLView::childrenHandleDragAndDropC:/a/viewer/viewer/indra/llui/llview.cpp(833)
SecondLifeViewer!LLView::handleDragAndDropC:/a/viewer/viewer/indra/llui/llview.cpp(1095)
SecondLifeViewer!LLView::childrenHandleDragAndDropC:/a/viewer/viewer/indra/llui/llview.cpp(833)
SecondLifeViewer!LLView::handleDragAndDropC:/a/viewer/viewer/indra/llui/llview.cpp(1095)
SecondLifeViewer!LLToolDragAndDrop::dragOrDropC:/a/viewer/viewer/indra/newview/lltooldraganddrop.cpp(743)
SecondLifeViewer!LLToolDragAndDrop::handleMouseUpC:/a/viewer/viewer/indra/newview/lltooldraganddrop.cpp(476)
SecondLifeViewer!LLMouseHandler::handleAnyMouseClickC:/a/viewer/viewer/indra/llwindow/llmousehandler.cpp(53)
SecondLifeViewer!LLTool::handleAnyMouseClickC:/a/viewer/viewer/indra/newview/lltool.cpp(65)
SecondLifeViewer!LLViewerWindow::handleAnyMouseClickC:/a/viewer/viewer/indra/newview/llviewerwindow.cpp(1088)
SecondLifeViewer!LLViewerInput::handleMouseC:/a/viewer/viewer/indra/newview/llviewerinput.cpp(1666)
SecondLifeViewer!LLViewerWindow::handleMouseUpC:/a/viewer/viewer/indra/newview/llviewerwindow.cpp(1197)
SecondLifeViewer!`LLWindowWin32::mainWindowProc'::`72'::::operator()C:/a/viewer/viewer/indra/llwindow/llwindowwin32.cpp(2679)
SecondLifeViewer!std::_Func_class::operator()C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Tools/MSVC/14.42.34433/include/functional(920)
SecondLifeViewer!LLWindowWin32::gatherInputC:/a/viewer/viewer/indra/llwindow/llwindowwin32.cpp(2249)
SecondLifeViewer!LLAppViewer::doFrameC:/a/viewer/viewer/indra/newview/llappviewer.cpp(1551)
SecondLifeViewer!LLAppViewer::frameC:/a/viewer/viewer/indra/newview/llappviewer.cpp(1432)
SecondLifeViewer!wWinMainC:/a/viewer/viewer/indra/newview/llappviewerwin32.cpp(499)
SecondLifeViewer!invoke_mainD:/a/_work/1/s/src/vctools/crt/vcstartup/src/startup/exe_common.inl(118)
SecondLifeViewer!__scrt_common_main_sehD:/a/_work/1/s/src/vctools/crt/vcstartup/src/startup/exe_common.inl(288)
kernel32!BaseThreadInitThunk
ntdll!RtlUserThreadStart
@AtlasLinden
Copy link

Steps to reproduce:

  1. Open 2 Inventory windows
  2. Drag an item from the new Favorites tab to the Inventory tab
  3. Viewer crashes

May require some further initial steps. First adding an item to Favorites, etc. Investigating...

@AtlasLinden AtlasLinden added the maint-pe Issues for Maint releases / Product Engine label Jan 9, 2025
@AtlasLinden AtlasLinden added this to the Maintenance C milestone Jan 9, 2025
@maxim-productengine maxim-productengine self-assigned this Jan 9, 2025
@AtlasLinden
Copy link

Another repro:
Dragging a favorited item that "Create folder from selected" was previously used with into another folder. See #3379
Seems to only sometimes crash

akleshchev added a commit that referenced this issue Jan 9, 2025
@akleshchev
#3374 LLFolderViewFolder::updateHasFavorites
1667ca4
akleshchev added a commit that referenced this issue Jan 9, 2025
@akleshchev
#3374 LLFolderViewFolder::updateHasFavorites
c8a14f9
akleshchev added a commit that referenced this issue Jan 9, 2025
@akleshchev
#3374 LLFolderViewFolder::updateHasFavorites
d54b80b
akleshchev added a commit that referenced this issue Jan 9, 2025
@akleshchev
#3374 Fix item reparenting moving containing folder
54fc7e5
akleshchev added a commit that referenced this issue Jan 9, 2025
@akleshchev
#3374 Fix item reparenting moving containing folder
80b714c
akleshchev added a commit that referenced this issue Jan 10, 2025
@akleshchev
#3374 LLFolderViewFolder::updateHasFavorites
fa837ba
akleshchev added a commit that referenced this issue Jan 10, 2025
@akleshchev
#3374 Fix item reparenting moving containing folder
acf7816
@akleshchev akleshchev linked a pull request Jan 10, 2025 that will close this issue
#3374 LLFolderViewFolder::updateHasFavorites #3381
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akleshchev akleshchev

Labels
bugsplat maint-pe Issues for Maint releases / Product Engine team:viewer
Projects
None yet
Milestone
Maintenance C
Development

Successfully merging a pull request may close this issue.

#3374 LLFolderViewFolder::updateHasFavorites secondlife/viewer
4 participants
@sl-service-account @AtlasLinden @akleshchev @maxim-productengine