Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow empty covariate list in gwas_linear_regression #509

Closed
tomwhite opened this issue Mar 23, 2021 · 0 comments · Fixed by #513
Closed

Allow empty covariate list in gwas_linear_regression #509

tomwhite opened this issue Mar 23, 2021 · 0 comments · Fixed by #513
Labels
core operations Issues related to domain-specific functionality such as LD pruning, PCA, association testing, etc.

Comments

@tomwhite
Copy link
Collaborator

In #463, the linear regression is first run with no covariates (i.e. only with an intercept). This is not possible with the current implementation of gwas_linear_regression, so we should add that capability. (There should be a check to see that add_intercept is True in the case of no covariates.)
@tomwhite tomwhite added the core operations Issues related to domain-specific functionality such as LD pruning, PCA, association testing, etc. label Mar 23, 2021
@tomwhite tomwhite mentioned this issue Mar 23, 2021
Closed
tomwhite added a commit to tomwhite/sgkit that referenced this issue Mar 31, 2021
@tomwhite
In gwas_linear_regression allow empty covariates sgkit-dev#509
42c8ac2
@tomwhite tomwhite mentioned this issue Mar 31, 2021
Merged
@mergify mergify bot closed this as completed in #513 Apr 19, 2021
mergify bot pushed a commit that referenced this issue Apr 19, 2021
@tomwhite @mergify
In gwas_linear_regression allow empty covariates #509
4394a14
@tomwhite tomwhite mentioned this issue Sep 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core operations Issues related to domain-specific functionality such as LD pruning, PCA, association testing, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

In gwas_linear_regression allow empty covariates #509 tomwhite/sgkit
1 participant
@tomwhite