Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WalletConnect dApps linking does not work on Android #86

Open
firebomb1 opened this issue Feb 1, 2023 · 1 comment
Open

WalletConnect dApps linking does not work on Android #86

firebomb1 opened this issue Feb 1, 2023 · 1 comment

Comments

@firebomb1
Copy link

firebomb1 commented Feb 1, 2023

When attempting to connect from a website using Chrome or Firefox on Android, intending to use the new WalletConnect dApps linking feature, ShapeShift does not show up in the list of potential apps that could be used to open the WalletConnect deeplink.

This makes the WalletConnect dApp feature harder to use as you need to copy/paste the non-default option through the QR code. I'm not sure if many users will find it either as it requires for the user to open the NavBar which is collapsed to click on "Connect dApp".

The fix should be to add an intent-filter entry to support the wc:deeplink scheme as described in the WalletConnect documentation in AndroidManifest.xml. We could maybe handle this in the PR #85 that intends to already add shapeshift:// deeplink support.

EDIT: It does imply more changes than just the intent-filter, the links need to be handled to trigger a WalletConnect connection or other operations in the app and/or the mobile-app as far as I could test.

Screenshot of the missing "ShapeShift" option while trying to link an app using WalletConnect:
image

@firebomb1
Copy link
Author

I don't have an iPhone and it seems the handling is different (they use WalletConnect's registry, in which our app is referenced, so it might work better). It would still be a good idea to test dApps linking using WallectConnect on iOs anyways!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant