Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support simultanious client connections #40

Open
ethanpailes opened this issue Jun 13, 2024 · 4 comments
Open

support simultanious client connections #40

ethanpailes opened this issue Jun 13, 2024 · 4 comments
Labels
big This will require a lot of work enhancement New feature or request

Comments

@ethanpailes
Copy link
Contributor

Several people have brought up this feature as a nice thing to have. This could actually be somewhat tricky given shpool's existing architecture because of the way we have a per-session lock.

We may want to have a notion of readwrite sessions and readonly sessions the same way that abduco does.

@digitalsignalperson
Copy link

It's nice with e.g. screen multiple people can connect to the same session for troubleshooting / "CLI screenshare".

@ethanpailes
Copy link
Contributor Author

Multiple people talking to the same shpool session may run into trouble because we currently protect against one user connecting to the daemon belonging to a different user to protect against priviledge escelation. I suppose we could add an off-by-default config option to allow this though.

@ethanpailes ethanpailes added enhancement New feature or request big This will require a lot of work labels Jun 24, 2024
@kflk
Copy link

kflk commented Jun 28, 2024

What about the case of multiple cursors for live co-editing? You can see work by Zellij, Kitty, and Helix:

Share your Terminal with Multiple Cursors
https://zellij.dev/news/multiplayer-sessions/

Protocol extension: multiple cursors · Issue #720 · kovidgoyal/kitty
kovidgoyal/kitty#720

Something similar to VS Code Live Share · helix-editor/helix · Discussion #8568
helix-editor/helix#8568

@ethanpailes
Copy link
Contributor Author

While supporting simultanious connections is a possibility for shpool, I don't think multiple cursors is in the cards. Merely mirroring sessions can be easily done in a shell-agnostic way, but multiple cursors would require knowing much more about how the inner shell works than shpool is able to know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
big This will require a lot of work enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants