Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Docker image for Splunk Operator #381

Merged
merged 4 commits into from
Dec 5, 2023

Conversation

@Kielek Kielek requested review from a team as code owners December 1, 2023 10:54
Copy link

github-actions bot commented Dec 1, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@theletterf
Copy link
Contributor

I have read the CLA Document and I hereby sign the CLA

srv-gh-o11y-gdi-cla added a commit to splunk/cla-agreement that referenced this pull request Dec 1, 2023
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
Co-authored-by: Paulo Janotti <[email protected]>
@jvoravong
Copy link

That PR mostly looks good to me. Trying to setup a demo or tests using this new docker image today to see if we are missing anything. Will approve or request needed changes after.

Copy link

@jvoravong jvoravong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't find any obvious issues with the Docker image. While I haven't been able to fully test it yet, the changes should be sufficient. LGTM.

@pjanotti pjanotti merged commit 4f6c502 into signalfx:main Dec 5, 2023
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2023
@Kielek Kielek deleted the splunk-operator-docker-image branch December 6, 2023 05:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants