-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Docker image for Splunk Operator #381
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
Co-authored-by: Paulo Janotti <[email protected]>
That PR mostly looks good to me. Trying to setup a demo or tests using this new docker image today to see if we are missing anything. Will approve or request needed changes after. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't find any obvious issues with the Docker image. While I haven't been able to fully test it yet, the changes should be sufficient. LGTM.
@jvoravong please review.
You can check the build on my fork https://github.com/Kielek/splunk-otel-dotnet/actions/runs/7059027432/job/19215767446 and test the docker image by
ghcr.io/kielek/splunk-otel-dotnet/splunk-otel-dotnet:latest
.Created based on