-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The script returns '-2147483648' in the TSV file if any value is a period ('.') in the Sample ID column of the VCF file. #2
Comments
Thanks @razshaikh for letting me know about this error! Could you share your VCF with me, so I can test and make sure that it can be fixed? It might be related to the underlying library (cyvcf), but I will check and see if I can fix it. best, |
Hi @sigven, thank you for your response, Really appreciated. |
Hi @sigven, any suggestions on how to solve this issue. Thanks and Regards, |
Hi @razshaikh, |
Hi @sigven, I understand you must be having other tasks on your hand. I really appreciated you looking into it. Thank you. |
Hi again @razshaikh, Been digging a bit, and it seems this matter is related to how cyvcf2 works. See this related issue, for instance. Either way, I have now added a simple check for this in vcf2tsv (v0.3.6), which should fix the error you encountered. On another note, your test VCF was full of other strange formatting errors, so I had to change it quite a bit for a test run. kind regards, |
Hi @sigven, Thank you for the update. I checked it, and it works for the 'GQ' values, but other values still has the same issue. For example: the values in AD column, if any value is missing and has a period('.') instead, the latest script still replaces it with '-2147483648'. Let me know if you have any suggestions for it. Thanks and regards, |
Hi @sigven I have added a pull request, let me know if that makes sense. Best wishes, |
No description provided.
The text was updated successfully, but these errors were encountered: