-
Notifications
You must be signed in to change notification settings - Fork 0
create common testing framework #33
Comments
We have analyzed how to continue with the solution of this and other issues. It is true that the code of these tests overlap, but we do not have any reference about how to deal with this. |
Testing both wrappers to ensure that they both behave in the same manner is good. Here, the problem lies in the code duplication; the tests are identical (only which wrapper is running is different). By fixing this issue, maintenance of existing tests will be easier and it will also be easier to extend the tests as well.
For example, there is a file-io and internal wrapper for lammps where there are common tests that run for each wrapper. See https://github.com/simphony/simphony-lammps-md/blob/master/simlammps/tests/test_lammps_wrapper.py and https://github.com/simphony/simphony-lammps-md/blob/master/simlammps/testing/abc_lammps_md_engine_check.py. There are additional examples of testing templates in symphony-common for testing of the concrete classes of ABCMesh etc. |
create common testing framework for both test_internalwrapper.py and tests/test_controlwrapper.py whose code overlaps
The text was updated successfully, but these errors were encountered: