Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Must call ripples({}) before using ripples('drop' #74

Open
salcott opened this issue Nov 24, 2020 · 1 comment
Open

Must call ripples({}) before using ripples('drop' #74

salcott opened this issue Nov 24, 2020 · 1 comment

Comments

@salcott
Copy link

salcott commented Nov 24, 2020

Trying to use this library (thank you, by the way, it is beautiful) and didn't realize you have to call ripples() on the target element before trying to call ripples() with the 'drop' method option. This should be added in the docs, used quite a few hours working to figure it out.

@sirxemic
Copy link
Owner

sirxemic commented Dec 2, 2020

I don't know what's expected from jQuery plugins these days (I haven't used jQuery in forever), but the readme does say that you initialize the plugin by calling .ripples() or .ripples(options). Did you miss that part or is the phrasing perhaps a bit ambiguous and can it be improved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants