Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carbon Ad CSS Stylesheet regression #2156

Closed
endigo9740 opened this issue Oct 18, 2023 · 1 comment · Fixed by #2157
Closed

Carbon Ad CSS Stylesheet regression #2156

endigo9740 opened this issue Oct 18, 2023 · 1 comment · Fixed by #2157
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@endigo9740
Copy link
Contributor

endigo9740 commented Oct 18, 2023

Link to the Page

All inner pages

Describe the Issue (screenshots encouraged!)

It looks like in the transition to v2 our ad-specific stylesheets was accidentally removed. This means the ads are reverted to their default styles. We need to investigate and resolve.

@endigo9740 endigo9740 added bug Something isn't working documentation Improvements or additions to documentation labels Oct 18, 2023
@endigo9740 endigo9740 self-assigned this Oct 18, 2023
@endigo9740
Copy link
Contributor Author

endigo9740 commented Oct 18, 2023

Turns out the PurgeCSS plugin was purging the ad styles because they are not used in the app at build time. Rather, the ads are injected with JS, so they don't appear until after this process. Extended the regex for the PurgeCSS in the vite.config.ts file to cover this use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant