Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Low test coverage for some of the JS modules #201

Open
bjfletcher opened this issue Apr 25, 2014 · 2 comments
Open

Low test coverage for some of the JS modules #201

bjfletcher opened this issue Apr 25, 2014 · 2 comments
Assignees
@elliottheis
Labels
tests
Milestone
Pre-componentization

Comments

@bjfletcher
Copy link
Contributor

Some JS modules had low test coverage:

     [ ]  'src/js/toolkit/components/tooltip.js': 41,
     [ ]  'src/js/toolkit/utils/polyfill.js': 67,
     [x]  'src/js/toolkit/utils/responsive-images.js': 40,
     [ ]  'src/js/toolkit/utils/skycons.js': 54,
     [ ]  'src/js/toolkit/utils/validation.js': 44

Let's get them to 70% or better, if not too difficult. If they're irrelevant or not used, then have them moved or deleted.
@peter-mouland peter-mouland added this to the 2.3-Idray-the-Winter-King milestone May 1, 2014
@peter-mouland
Copy link
Contributor

moved this to milestone 2.3 as low test coverage should be fixed sooner rather than later!

@bjfletcher
Copy link
Contributor Author

responsive images now 85%

@peter-mouland peter-mouland modified the milestones: 2.3-Idray-the-Winter-King, Pre-componentization Aug 27, 2014
@elliottheis elliottheis self-assigned this Aug 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elliottheis elliottheis

Labels
tests
Projects
None yet
Milestone
Pre-componentization
Development

No branches or pull requests
3 participants
@elliottheis @bjfletcher @peter-mouland