Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename "in-page nav"/"sleek nav"/"whole page nav" to 'tabs' #218

Open
ninadel opened this issue May 8, 2014 · 4 comments
Open

rename "in-page nav"/"sleek nav"/"whole page nav" to 'tabs' #218

ninadel opened this issue May 8, 2014 · 4 comments

Comments

@ninadel
Copy link

ninadel commented May 8, 2014

I would suggest that labels for these headings be more descriptive, as nav could pertain to lots of different UI types

sleek nav => modular tabs
whole page nav => page tabs

we will eventually add a design section that will include navigation patterns (pages 22-27 of the guidelines PDF), so to prevent future confusion would be better to avoid the word 'nav' in the component section if possible.

@peter-mouland
Copy link
Contributor

moved this to milestone 2.3 as a thanks for designs input :)

@peter-mouland peter-mouland added this to the 2.3-Idray-the-Winter-King milestone May 16, 2014
@peter-mouland
Copy link
Contributor

we would have to work out if the css/js should also change to match and whether or not we keep alias' to the old function so as not to be a breaking change. If we keep the alias, it would be worth starting a 3.0 milestone listing the alias' to remove.

@charypar
Copy link
Contributor

Is there a way to also safely print deprecation warnings without causing issues?

@peter-mouland
Copy link
Contributor

yeah, good point. So docs would need to be updated to the new version and in the code we should detect console and then console.info or something that makes sense to let the dev know.

@peter-mouland peter-mouland modified the milestones: 2.3-Idray-the-Winter-King, componentization Aug 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants