Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.has-focus background-color #226

Open
elliottheis opened this issue May 20, 2014 · 4 comments
Open

.has-focus background-color #226

elliottheis opened this issue May 20, 2014 · 4 comments

Comments

@elliottheis
Copy link
Contributor

There appears to be a background-color being set when an input is in focus.

Should this be descoped from input-esque elements, or removed altogether?

commit that introduced it

@peter-mouland
Copy link
Contributor

the has-focus class is added if a user tabs through the page. The intent is to make it more obvious where the user is on the page for accessibility reasons.
If you wanted to remove it, what would you replace it with?

@elliottheis
Copy link
Contributor Author

I think the background-color property should be set when tabbing on all elements excluding input-esque elements?
screen shot 2014-05-20 at 14 13 06

@peter-mouland
Copy link
Contributor

yeah, feel free to submit a pull request with the background colour replaced with another style.

If the style within sky-form (or whatever the toolkit forms are) include a border width already then, for these forms we could safely change the colour of border. We couldn't for example use border: 1px solid blue on forms where we don't know if borders are being used as this would cause a 'jump' when the element is focused on. Just something to remember.

Could you also ensure that it has gone through proper design/accessibility checks. Previously we went through nomensa, but i'm not sure if they would have seen the affect on forms.

@pigats
Copy link

pigats commented Aug 12, 2015

/cc @aldreth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants