Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests ensuring modal requests can start when conditional ones are running #35

Open
Firehed opened this issue Jul 28, 2024 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@Firehed
Copy link
Contributor

Firehed commented Jul 28, 2024

Generally:

async let autofillResult = await snapAuth.handleAutofill()
let modalResult = await snapAuth.startAuth(.handle("Test"))

I don't know enough about how to do UI testing to handle the modal situation, plus all of the network requests should ideally get mocked out. But this seems like a high-risk area for data races (even with Swift 6, in my limited testing; it's a logic problem rather than a synchronization one) and it will likely balloon in scope with #27.

@Firehed Firehed added the help wanted Extra attention is needed label Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant