Support for Django 5

[dicknetherlands]

Django 5 has been released but django-auth-adfs supports only versions up to 4.2. Is there a roadmap/timeline for adding Django 5 support?

Upvote & Fund

• We're using Polar.sh so you can upvote and help fund this issue.
• We receive the funding once the issue is completed & confirmed by you.
• Thank you in advance for helping prioritize & fund our backlog.

[tim-schilling]

I think right now it's when someone has time to do it. I have no reason to think there's a break. We probably just need to update the test suite, classifies and cut a new release. If you'd like to help that along, you could create a PR for the first two tasks.

…

On Mon, Dec 4, 2023, 1:41 PM Richard Holland ***@***.***> wrote: Django 5 has been released but django-auth-adfs supports only versions up to 4.2. Is there a roadmap/timeline for adding Django 5 support? Upvote & Fund - We're using Polar.sh <https://polar.sh/snok> so you can upvote and help fund this issue. - We receive the funding once the issue is completed & confirmed by you. - Thank you in advance for helping prioritize & fund our backlog. [image: Fund with Polar] <https://polar.sh/snok/django-auth-adfs/issues/311> — Reply to this email directly, view it on GitHub <#311>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJYZP32XSNQ63S6YI2UDHLYHYRPTAVCNFSM6AAAAABAGQPSYGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAZDINJZGI2TAMA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[dicknetherlands]

I think right now it's when someone has time to do it. I have no reason to think there's a break. We probably just need to update the test suite, classifies and cut a new release. If you'd like to help that along, you could create a PR for the first two tasks.

No problem. PR created. I removed Python 3.7 support too because the tests were no longer able to install or run it, and fixed a linting issue (Duplicating some work from #307 in order to get tests to run!). Tests seem to be passing but for some reason coverage is not? Looking hopeful though.

[tim-schilling]

@dicknetherlands thank you for your help. This is being released today.