Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1878222: Any plans to update the @aws-sdk/client-s3 and @smithy/node-http-handler libraries? #991

Open
spdaley opened this issue Jan 10, 2025 · 3 comments
Open

SNOW-1878222: Any plans to update the @aws-sdk/client-s3 and @smithy/node-http-handler libraries? #991

spdaley opened this issue Jan 10, 2025 · 3 comments
Assignees
@sfc-gh-dszmolka
Labels
enhancement The issue is a request for improvement or a new feature status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. status-triage_done Initial triage done, will be further handled by the driver team

Comments

@spdaley
Copy link

spdaley commented Jan 10, 2025

Smithy recently dropped support for node 16 leading them to create major version 4 of their libraries.
The most recent version of the @AWS-SDK libraries now uses the v4 smithy libraries as well.

It looks like the minimum supported node version for snowflake-sdk is 18 so it seems like you could go with those libraries. I understand their may be other reasons you can't update though so just figured I'd ask the question.

Thanks!
@sfc-gh-dszmolka sfc-gh-dszmolka self-assigned this Jan 10, 2025
@sfc-gh-dszmolka sfc-gh-dszmolka added enhancement The issue is a request for improvement or a new feature status-triage_done Initial triage done, will be further handled by the driver team labels Jan 10, 2025
@sfc-gh-dszmolka
Copy link
Collaborator

hi and thanks for raising this issue !

  1. @aws-sdk/client-s3 latest is v3.726.0, we install v3.726.0
# npm list @aws-sdk/client-s3
test@ /test
`-- [email protected]
  `-- @aws-sdk/[email protected]
  1. @smithy/node-http-handler latest is v4.0.1 (major v4 released 4 days ago only)
# npm list @smithy/node-http-handler
test@ /test
`-- [email protected]
  +-- @aws-sdk/[email protected]
  | +-- @aws-sdk/[email protected]
  | | `-- @smithy/[email protected]
  | +-- @aws-sdk/[email protected]
  | | `-- @smithy/[email protected]
  | +-- @aws-sdk/[email protected]
  | | +-- @aws-sdk/[email protected]
  | | | `-- @smithy/[email protected]
  | | `-- @aws-sdk/[email protected]
  | |   `-- @aws-sdk/[email protected]
  | |     `-- @smithy/[email protected]
  | +-- @smithy/[email protected]
  | `-- @smithy/[email protected]
  |   `-- @smithy/[email protected]
  `-- @smithy/[email protected]

we install 3.3.3 but dependencies already install 4.0.1, i guess we can bump it too

@sfc-gh-dszmolka sfc-gh-dszmolka changed the title Any plans to update the @aws-sdk/client-s3 and @smithy/node-http-handler libraries? SNOW-1878222: Any plans to update the @aws-sdk/client-s3 and @smithy/node-http-handler libraries? Jan 10, 2025
@sfc-gh-dszmolka
Copy link
Collaborator

#992

@sfc-gh-dszmolka sfc-gh-dszmolka added the status-pr_pending_merge A PR is made and is under review label Jan 10, 2025
@sfc-gh-dszmolka
Copy link
Collaborator

change is merged and will be part of the next release

@sfc-gh-dszmolka sfc-gh-dszmolka added status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. and removed status-pr_pending_merge A PR is made and is under review labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfc-gh-dszmolka sfc-gh-dszmolka

Labels
enhancement The issue is a request for improvement or a new feature status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. status-triage_done Initial triage done, will be further handled by the driver team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spdaley @sfc-gh-dszmolka