Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexible pedigree view #4985

Open
chris263 opened this issue Jun 24, 2024 · 3 comments
Open

Flexible pedigree view #4985

chris263 opened this issue Jun 24, 2024 · 3 comments
Assignees
Labels
Priority: High Issue/PR significantly impacts users.

Comments

@chris263
Copy link
Contributor

Expected Behavior

Pedigree view is showing only one name as parent when the pedigree comes from a self. It also would be transfered to field book app.
Expected results:
1 - Transfer only one name as parent to field book if the crossing type is "self".
2 - Make this configuration available in sgn_local.conf. (I believe, some breeding programs still want to see two parental names).

pedigreeview

For Bugs:

Environment

Steps to Reproduce

@chris263 chris263 added the Priority: High Issue/PR significantly impacts users. label Jun 24, 2024
@bellerbrock
Copy link
Member

Related to #4828 which outlines some fixes needed to make the current pedigree string implementation fully match Purdy notation

@chris263 what does the program you're working with expect for pedigree notation? The example string is ugly but I think expected for Purdy notation,. It just looks like their conventions may be incompatible with Purdy since they have / and ( in their accession names.

@chris263
Copy link
Contributor Author

chris263 commented Jun 25, 2024

The pedigree view looks fine. What they expect is to pass the same information (just 1 parent if the cross is self) to the field book app.

They have a very complex naming convention. However, it is pretty consolidated in the company (actually, it is used for more than than one company in many countries). Here are the symbols they are using:

<style> table { width: 50%; border-collapse: collapse; } table, th, td { border: 1px solid black; } th, td { padding: 10px; text-align: left; } </style>
Character Description
/ 50% each parent
. 25.00%
+ 12.50%
: 6.25%
) Ear selection method
X Self pollination in bulk
@@ Double haploid

Here is an example:
A015.A105/E038.A038)X2B3

@bellerbrock
Copy link
Member

Ah, ok, good details. Purdy was developed with wheat if I'm remembering correctly, sounds like this system is more specific to corn? Does it have a name?

If it's implemented alongside purdy notation and the existing options for pedigree string, then I like the idea you mentioned of setting the default pedigree string format in the conf file. That way everyone should be able to get the version they expect in Field Book as long as the BrAPI germplasm endpoint returns the default string.

If they need access to multiple version of the string then it will be important to update the BrAPI spec: plantbreeding/BrAPI#589

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High Issue/PR significantly impacts users.
Projects
None yet
Development

No branches or pull requests

3 participants