You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When reviewing changes implemented in acstools PR #46, I came across an issue when testing some updated functionality that allows for saving of intermediate products in our stand-alone destriping routine, acs_destripe_plus. The logic implemented in the updates to acs_destripe_plus to allow for the saving of intermediate files is correct (see L506), the issue is that the preceding to call acs2d (L501) is deleting the reference files.
As it stands, only the calacs.e executable has the command line argument -s defined and it is this argument that tells calacs.e not to delete the intermediate data products (blv_tmp.fits, blc_tmp.fits).
(astroconda3) nmiles@nathan:~$acs2d.e syntax: acs2d [--help] [-t] [-v] [-q] [--version] [--gitinfo] input output(astroconda3) nmiles@nathan:~$acsccd.esyntax: acsccd [--help] [-t] [-v] [-q] [--version] [--gitinfo] input output(astroconda3) nmiles@nathan:~$acscte.esyntax: acscte.e [--help] [-t] [-v] [-q] [--version] [--gitinfo] [-1|--nthreads <N>] [--ctegen <1|2>] [--pctetab <path>] input [output](astroconda3) nmiles@nathan:~$acssum.esyntax: acssum [--help] [-t] [-v] [-q] [--version] [--gitinfo] input [output](astroconda3) nmiles@nathan:~$acsrej.eSyntax error: acsrej.e input output [-t] [-v] [-shadcorr] [-crmask] [-readnoise_only] [-table <filename>] [-scale #] [-init (med|min)] [-sky (none|mode)] [-sigmas #] [-radius #] [-thresh #] [-pdq #]input comma-delimited string (e.g., filename or filename1,filename2,filename3)output string-t print timestamps-v turn on verbose mode-shadcorr turn on shutter shading correction (intended for CCD images only)-crmask flag CR-rejected pixels in the input files-readnoise_only use read noise and not Poission noise to create ERR array (intended for BIAS images)-table filename cosmic ray rejection table to use for default parameter values-scale # multiplicative factor (in percent) applied to noise-init med|min scheme for computing initial guess image (median or minimum)-sky none|mode scheme for computing sky levels to be subtracted (none:0.0 or mode:most frequently occurring value)-sigmas #[,#...] cosmic ray rejection thresholds, no. of thresholds are the no. of iterations-radius # radius (in pixels) to propagate the cosmic ray-thresh # cosmic ray rejection propagation threshold-pdq # data quality flag used for cosmic ray rejection(astroconda3) nmiles@nathan:~$calacs.eCALACS Version 10.0.0syntax: calacs.e [--help] [-t] [-s] [-v] [-q] [-r] [--version] [--gitinfo] [-1|--nthreads <N>] [--ctegen <1|2>] [--pctetab <path>] input
It would be ideal if we could standardized the commonly used command line arguments across all the underlying calacs.e executables, so that means each routine would have --help, -t, -s, -v, -q, --version, --gitinfo.
The text was updated successfully, but these errors were encountered:
When reviewing changes implemented in
acstools
PR #46, I came across an issue when testing some updated functionality that allows for saving of intermediate products in our stand-alone destriping routine, acs_destripe_plus. The logic implemented in the updates toacs_destripe_plus
to allow for the saving of intermediate files is correct (see L506), the issue is that the preceding to callacs2d
(L501) is deleting the reference files.As it stands, only the
calacs.e
executable has the command line argument-s
defined and it is this argument that tellscalacs.e
not to delete the intermediate data products (blv_tmp.fits, blc_tmp.fits).It would be ideal if we could standardized the commonly used command line arguments across all the underlying
calacs.e
executables, so that means each routine would have--help
,-t
,-s
,-v
,-q
,--version
,--gitinfo
.The text was updated successfully, but these errors were encountered: